Remove redundant placeholder for login form #4918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelvinBot
requested review from
stitesExpensify
and removed request for
a team
stitesExpensify
approved these changes
Aug 31, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Aug 31, 2021
|
🚀 Deployed to staging by @stitesExpensify in version: 1.0.90-3 🚀
|
|
@stitesExpensify @ctkochan22 Can you please confirm on what platforms do we need to QA this PR? |
|
All of the platforms? Or at least web and iOS |
|
🚀 Deployed to production by @roryabraham in version: 1.0.91-0 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Expensify/pullerbear
Details
We have a redundant placeholder. Just removing it.
Fixed Issues
$ #4738
Tests
Start up a local env of the app. Sign out if necessary. Verify that the login screen no longer has the label as well as the placeholder asking for the email.
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android